brotli: include static libs in build#58935
brotli: include static libs in build#58935NyaaaWhatsUpDoc wants to merge 1 commit intovoid-linux:masterfrom
Conversation
NyaaaWhatsUpDoc
force-pushed
the
brotli-add-static-libs
branch
from
651e6e0 to
6203cbb
Compare
| post_install() { | ||
| vlicense LICENSE | ||
|
|
||
| # Drop the -static suffix from static libs |
There was a problem hiding this comment.
Why? Upstream picks the name; if there is not a compelling reason to override it, it should remain as they intend.
There was a problem hiding this comment.
their pkg-config definition doesn't mention their static libraries with differing names, so without this change it means pkg-config --libs --static output won't point correctly to the static libraries. i'm happy to remove the change if you'd prefer to stick to upstream behaviour still, but this update was to make pkg-config with brotli-devel work more as expected. let me know which you'd prefer :)
There was a problem hiding this comment.
You should submit this fix upstream, and defer adding static libraries to this package until they decide how they want to resolve the matter.
There was a problem hiding this comment.
it's a known issue that after years they haven't decided on a fix yet unfortunately google/brotli#795
alpine's solution is to perform 2 separate build steps which is something we could alternatively do: https://gitlab.alpinelinux.org/alpine/aports/-/blob/3.19-stable/main/brotli/APKBUILD#L43
2 participants
Testing the changes
Updates the brotli template to build and include static library files in devel package.
cc: @leahneukirchen